Review main Merged Breaking

60799[!!!][TASK] Remove config.defaultGetVars

Benni Mack CR +2 V +2 Normal +3 −73 updated 05/24/19, 10:38

Commit message

The TypoScript option config.defaultGetVars is not
evaluated anymore, as this conflicts with TypoScript
logic itself:

After TypoScript parsing and condition evaluation in
a Frontend Request, config.defaultGetVars is set,
this would effectively mean that TypoScript
parsing should be re-done in order to meet new
possible matches in Conditions.

As this logic is flawed and should now easily be
handled via a custom middleware (previously this was
helpful for setting e.g. L=0 for default pages
with RealURL), it is now removed from Core.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6