Review main Abandoned

60803[TASK] Make initializeMailer() protected

Sascha Ternes CR 0 V 0 Easy +4 −2 updated 06/13/19, 07:43

Commit message

I want to make use of the Swift_Mailer plugin feature. Therefore I want to
extend the MailMessage class and prepare the Mailer in function
initializeMailer().

Changing this method from private to protected makes it possible to just
overwrite it in subclasses, without the need to overwrite the whole send()
method.

I wanted to keep the change small. We could call initializeMailer() in the
constructor. We could also introduce a getter for the mailer object. That
may be something for a FEATURE.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1