Review main Merged

60865[BUGFIX] Simplify item states in Menu Generation

Benni Mack CR +2 V +2 Normal +31 −150 updated 06/27/19, 12:40

Commit message

The same if() loop is used for checking menu generation item states
(ACT/IFSUB etc), this can be very much simplified by using
a loop over the available item states which are now defined
as a constant.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Gorges +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Gorges +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 06/03/19, 11:12

  2. TYPO3com voted on patch set 1 V +1 06/03/19, 11:26 Completed build in 13m 45s on Mon, 3 Jun, 01:26 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34144

  3. Susi Moog voted on patch set 1 V +1 CR +1 06/21/19, 09:34

  4. Daniel Gorges voted on patch set 1 V +1 CR +1 06/27/19, 10:54

  5. Benni Mack voted on patch set 1 V +2 CR +2 06/27/19, 11:56

  6. Benni Mack merged patch set 2 06/27/19, 11:56

  7. Tymoteusz Motylewski commented on patch set 2 06/27/19, 12:40

    lol, that's a nice refactoring!