Review TYPO3_8-7 Merged

60884[BUGFIX] Prevent division by zero when scaling image

Anja Leichsenring CR +2 V +2 Easy +16 −2 updated 06/05/19, 20:46

Commit message

Prevents multiple division by zero errors when scaling
images, by checking that the input image size is valid
(meaning non-zero) before attempting to calculate
the ratio for scaling - because the ratio is based on the
input size parameters that must not be zero.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Anja Leichsenring commented on patch set 1 06/05/19, 20:12

    Cherry Picked from branch 9.5.
  2. TYPO3com voted on patch set 1 V +1 06/05/19, 20:40 Completed build in 27m 30s on Wed, 5 Jun, 10:40 PM Test Summary: 80310 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3541

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 06/05/19, 20:46

  4. Anja Leichsenring merged patch set 2 06/05/19, 20:46