60887[!!!][TASK] Drop DB field sys_language.static_lang_isocode
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Daniel Goerz +1
- Oliver Klee +1
- Björn Jacob +1
-
Verified V +2 Done
- Andreas Kienast +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1418
-
Benni Mack uploaded patch set 1 06/06/19, 05:10
-
TYPO3com voted on patch set 1 V -1 06/06/19, 05:21 Completed build in 10m 16s on Thu, 6 Jun, 07:21 AM Test Summary: 36 of 46833 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34216
-
Benni Mack commented on patch set 1 06/06/19, 06:00
ah, great. testing framework provides its own sys_language datasets :( -
Benni Mack rebased onto patch set 2 06/18/19, 09:54
-
TYPO3com voted on patch set 2 V -1 06/18/19, 10:10 Completed build in 15m 38s on Tue, 18 Jun, 12:10 PM Test Summary: 36 of 46793 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34415
-
Benni Mack uploaded patch set 3 06/18/19, 10:20
-
TYPO3com voted on patch set 3 V +1 06/18/19, 10:59 Completed build in 38m 44s on Tue, 18 Jun, 12:59 PM Test Summary: 46442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34419
-
Oliver Klee voted on patch set 3 CR +1 06/18/19, 13:33
-
Alexander Schnitzler commented on patch set 3 06/18/19, 14:16
Breaking-88583-DatabaseFieldSys_languagestatic_lang_isocodeRemoved.rst:14meta-dataa -> meta-dataBreaking-88583-DatabaseFieldSys_languagestatic_lang_isocodeRemoved.rst:16I don't see any TCA being removed.Breaking-88583-DatabaseFieldSys_languagestatic_lang_isocodeRemoved.rst:35"an extensions code" sounds strange. Maybe just: "if not needed by an extension"? -
Daniel Gorges voted on patch set 3 V +1 CR +1 06/25/19, 04:31
-
Daniel Goerz commented on patch set 3 06/27/19, 12:45
Breaking-88583-DatabaseFieldSys_languagestatic_lang_isocodeRemoved.rst:14ReplyDoneBreaking-88583-DatabaseFieldSys_languagestatic_lang_isocodeRemoved.rst:16ReplyDoneBreaking-88583-DatabaseFieldSys_languagestatic_lang_isocodeRemoved.rst:35ReplyDone -
Daniel Goerz uploaded patch set 4 06/27/19, 12:47
-
Daniel Goerz voted on patch set 4 V +1 CR +1 06/27/19, 12:48
-
Oliver Klee voted on patch set 4 CR +1 06/27/19, 12:55
-
TYPO3com voted on patch set 4 V +1 06/27/19, 13:11 Completed build in 23m 29s on Thu, 27 Jun, 03:11 PM Test Summary: 46520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34573
-
Björn Jacob voted on patch set 4 CR +1 06/28/19, 04:49
-
Andreas Kienast voted on patch set 4 V +2 CR +2 06/28/19, 07:50
-
Andreas Kienast merged patch set 5 06/28/19, 07:50