Review main Merged

60888Revert "[TASK] Drop t3_origuid fields from functional tests"

Oliver Hader CR +2 V +2 Impossible +5754 −5748 updated 06/06/19, 18:26

Commit message

This reverts commit 55f7beae9e8360c56f9f788774177d7572bbd901.

Unfortunately it's not possible to get rid of t3_origuid completely
without introducing new side-effects. Remaining test adjustments for
#88494 have shown that non-translatable entities used as reference
would rather be deleted & re-created instead of synchronized.

t3_origuid did a good job there - dropping it would introduce the
mentioned regression. Misusing l10n_source for a non-translatable
table sounds as stupid as introducing a new field like sync_origuid.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 295

Show 275 more files