Review main Merged

60946[BUGFIX] Use var path from Environment in tests

Susi Moog CR +2 V +2 Normal +68 −48 updated 06/21/19, 10:39

Commit message

Some tests still use hardcoded 'typo3temp' for creating files and folders.
Where possible, this has been changed to use varPath from Environment class
instead.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1014

  1. Susi Moog uploaded patch set 1 06/12/19, 11:16

  2. Susi Moog uploaded patch set 2 06/12/19, 11:29

  3. Susi Moog uploaded patch set 3 06/13/19, 07:17

  4. TYPO3com voted on patch set 3 V -1 06/13/19, 07:18 Completed build in 29s on Thu, 13 Jun, 09:18 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34304

  5. Susi Moog uploaded patch set 4 06/13/19, 07:23

  6. TYPO3com voted on patch set 4 V -1 06/13/19, 07:38 Completed build in 15m 01s on Thu, 13 Jun, 09:38 AM Test Summary: 46524 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34305

  7. Susi Moog uploaded patch set 5 06/20/19, 08:56

  8. TYPO3com voted on patch set 5 V +1 06/20/19, 09:07 Completed build in 11m 14s on Thu, 20 Jun, 11:07 AM Test Summary: 46448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34459

  9. Susi Moog updated the commit message in patch set 6 06/20/19, 09:16

  10. Susi Moog commented on patch set 6 06/20/19, 09:16

    This change is ready for review.
  11. TYPO3com voted on patch set 6 V +1 06/20/19, 09:27 Completed build in 11m 24s on Thu, 20 Jun, 11:27 AM Test Summary: 46448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34460

  12. Frank Nägler voted on patch set 6 V +1 CR +1 06/20/19, 10:12

  13. Benni Mack voted on patch set 6 V +2 CR +2 06/21/19, 05:39

  14. Susi Moog merged patch set 7 06/21/19, 10:39