Review main Merged

61002[TASK] Deprecate TSFE->sys_language_isocode

Benni Mack CR +2 V +2 Normal +58 −3 updated 06/28/19, 07:45

Commit message

Due to the introduction of Site Handling, the public property
`$TSFE->sys_language_isocode` is not necessary anymore,
as this value is used outside of TSFE fully, and not needed as
public property to hold the state.

It is marked as deprecated.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 69

  1. Benni Mack uploaded patch set 1 06/13/19, 13:31

  2. TYPO3com voted on patch set 1 V -1 06/13/19, 13:48 Completed build in 16m 47s on Thu, 13 Jun, 03:48 PM Test Summary: 52 of 46865 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34327

  3. Benni Mack rebased onto patch set 2 06/13/19, 14:57

  4. TYPO3com voted on patch set 2 V -1 06/13/19, 15:11 Completed build in 13m 32s on Thu, 13 Jun, 05:11 PM Test Summary: 46524 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34334

  5. Georg Ringer uploaded patch set 3 06/14/19, 02:03

  6. TYPO3com voted on patch set 3 V +1 06/14/19, 02:28 Completed build in 23m 52s on Fri, 14 Jun, 04:28 AM Test Summary: 46526 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34340

  7. Daniel Goerz voted on patch set 3 V +1 CR +1 06/27/19, 13:59

  8. Andreas Kienast voted on patch set 3 V +2 CR +2 06/28/19, 07:45

  9. Andreas Kienast merged patch set 4 06/28/19, 07:45