Review main Merged

61050[TASK] Move Slug Candidate functionality into its own class

Benni Mack CR +2 V +2 Hard +314 −222 updated 07/17/19, 18:15

Commit message

When Page-based slug handling + routing was introduced,
the initial PageRouter class turned big very quickly.

Especially managing the possible pages that could match
was initially based on the candidates principle that could
be moved / exchanged later-on.

For this to happen the initial step is to move this to a separate
PHP class called "PageSlugCandidateProvider".

As seen in the patch, all calls to the database related
to retrieving pages (DB + PageRepository) are
moved into PageSlugCandidateProvider.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3