Review 9.5 Merged

61093[BUGFIX] Speed up SiteConfiguration loading

Benni Mack CR +2 V +2 Normal +61 −22 updated 06/19/19, 12:22

Commit message

Profiling shows that when linking to 100
pages, SiteFinder (which instantiates SiteConfiguration)
is instantiated 100 times. Although SiteFinder information
might change during one request, the SiteConfiguration
does not (except when updating the Configuration via API).

So, a first-level-cache can be used to avoid calls
to "cache_core" multiple times during one request,
and SiteConfiguration can become a Singleton instance.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 45

  1. Benni Mack uploaded patch set 1 06/19/19, 11:24

  2. TYPO3com voted on patch set 1 V +1 06/19/19, 11:41 Completed build in 17m 41s on Wed, 19 Jun, 01:41 PM Test Summary: 50407 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-801

  3. Daniel Goerz voted on patch set 1 V +1 CR +1 06/19/19, 12:08

  4. Benni Mack voted on patch set 1 V +2 CR +2 06/19/19, 12:22

  5. Benni Mack merged patch set 2 06/19/19, 12:22