Review main Merged Breaking

61124[!!!][TASK] Handle SoftRefParser without references

Benni Mack CR +2 V +2 Normal +69 −18 updated 06/28/19, 07:32

Commit message

The softRefParser logic previously contained its own
factory within BackendUtility with a magic singleton
logic built into "$GLOBALS['T3_VAR']['softRefParser']".

This has changed by building custom Singleton
Interfaces instead.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 68

  1. Benni Mack uploaded patch set 1 06/25/19, 04:19

  2. TYPO3com voted on patch set 1 V +1 06/25/19, 04:34 Completed build in 14m 58s on Tue, 25 Jun, 06:34 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34523

  3. Benni Mack uploaded patch set 2 06/27/19, 11:24

  4. Andreas Kienast voted on patch set 2 CR +1 06/27/19, 11:37

  5. TYPO3com voted on patch set 2 V +1 06/27/19, 11:38 Completed build in 13m 54s on Thu, 27 Jun, 01:38 PM Test Summary: 46520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34565

  6. Daniel Goerz voted on patch set 2 V +1 CR +1 06/27/19, 14:40

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 06/28/19, 07:32

  8. Andreas Kienast merged patch set 3 06/28/19, 07:32