Review main Merged

61163[FEATURE] Set Twitter Card Type in page properties

Richard Haeser CR +2 V +2 Normal +189 −6 updated 06/28/19, 12:03

Commit message

This option will make it possible to select a type of Twitter Card
that should be used when your page is shared on Twitter.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Daniel Goerz +1
    • Björn Jacob +1
    • Riny van Tiggelen +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Daniel Goerz +1
    • Riny van Tiggelen +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 1619

  1. Richard Haeser uploaded patch set 1 06/27/19, 20:43

  2. Richard Haeser commented on patch set 1 CR -1 06/27/19, 20:44

    Will add tests
  3. TYPO3com voted on patch set 1 V +1 06/27/19, 20:53 Completed build in 10m 51s on Thu, 27 Jun, 10:53 PM Test Summary: 46520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34591

  4. Richard Haeser uploaded patch set 2 06/27/19, 21:51

  5. TYPO3com voted on patch set 2 V +1 06/27/19, 22:02 Completed build in 11m 12s on Fri, 28 Jun, 12:02 AM Test Summary: 46529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34592

  6. Kevin Appelt commented on patch set 2 V +1 CR +1 06/28/19, 04:43

    There are two more types (app and player) but I don’t think we need to add support of these by default. If one needs them they can be added by the developer/integrator for this special case. What do you think?
  7. Richard Haeser commented on patch set 2 06/28/19, 05:17

    I left them out on purpose. Those types needs additional info that we won’t provide out of the box. In this case, you always can add the option yourselves and add the additional info, but only when you need it. > Patch Set 2: Verified+1 Code-Review+1 > > There are two more types (app and player) but I don’t think we need to add support of these by default. If one needs them they can be added by the developer/integrator for this special case. What do you think?
  8. Björn Jacob voted on patch set 2 CR +1 06/28/19, 05:24

  9. Riny van Tiggelen voted on patch set 2 CR +1 06/28/19, 06:32

  10. Guido Schmechel commented on patch set 2 06/28/19, 08:22

    Feature-88648-DefineTwitterCardTypeInPageProperties.rst:20

    Can you add here an example? Like in your test file

    MetaTagGenerator.php:83 Unresolved

    Should we handle "summary" and "summary_large_image" as constants? Benefit: We can use it in TCA and other files (e.g. Tests)
  11. Guido Schmechel commented on patch set 2 06/28/19, 08:23

    > Patch Set 2: > > I left them out on purpose. Those types needs additional info that we won’t provide out of the box. In this case, you always can add the option yourselves and add the additional info, but only when you need it. This info would certainly be good for the RST file :-)
  12. Daniel Goerz commented on patch set 3 06/28/19, 08:47

    Published edit on patch set 2.
  13. Daniel Goerz commented on patch set 3 06/28/19, 08:47

    Feature-88648-DefineTwitterCardTypeInPageProperties.rst:20 Reply

    Done
  14. TYPO3com voted on patch set 3 V +1 06/28/19, 08:58 Completed build in 10m 54s on Fri, 28 Jun, 10:58 AM Test Summary: 46529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34598

  15. Daniel Goerz voted on patch set 3 V +1 CR +1 06/28/19, 09:44

  16. Björn Jacob voted on patch set 3 CR +1 06/28/19, 10:10

  17. Riny van Tiggelen voted on patch set 3 V +1 CR +1 06/28/19, 12:02

  18. Richard Haeser voted on patch set 3 V +2 CR +2 06/28/19, 12:03

  19. Richard Haeser merged patch set 4 06/28/19, 12:03