Review main Merged

61166[TASK] Move PageRepository to EXT:core

Benni Mack CR +2 V +2 Hard +217 −103 updated 07/17/19, 05:12

Commit message

Since Context API was introduced in TYPO3 v9, PageRepository is highly
decoupled from $TSFE->sys_page, and fully works standalone.

It is also used in various places where TSFE is not needed,
or required, but also in places of EXT:core.

Especially parts like RootlineUtility, which depends on PageRepository
very much, cannot live without it.

I propose to move this highly important PHP class into EXT:core,
in order to allow to decouple EXT:frontend even further from
EXT:core.

The FQCN is moved from
- \TYPO3\CMS\Frontend\Page\PageRepository
to
- TYPO3\CMS\Core\Domain\Repository\PageRepository

It can be assumed to use PageRepository for any use-case
and actually reduce usages towards BackendUtility::get...
by using this API more and more.

Further adaptions could be to reduce the logic
within PageRepository and move this into QueryBuilder
and assimilate especially the "versionOL" behavior.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 64

Show 44 more files