Review main Merged

61235[TASK] Remove dependencies of \TYPO3\CMS\Extbase\Mvc\Web\Request

Alexander Schnitzler CR +2 V +2 Normal +55 −75 updated 07/08/19, 20:04

Commit message

According to PSR-7 request objects should be immutable.
That can only be achieved if the state of the request
object is defined during construction. Therefore, the
web request object of Extbase mustn't have any service
dependencies that alter the state of the object during
runtime.

Although there are still setters that can alter the
state of request objects, the more crucial issue with
the object state were the injected services.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7