61239[Task] reformat and optimize code
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 27
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+3 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-88102-FeatureToggleForFE-loginPiBase.rstnew+22 −0
- typo3/sysext/felogin/Classes/Controller/LoginController.phpnew+193 −0
- typo3/sysext/felogin/Classes/Updates/MigrateFeloginPlugins.php+3 −1
- typo3/sysext/felogin/Classes/Updates/MigrateFeloginPluginsCtype.phpnew+160 −0
- typo3/sysext/felogin/Classes/Validation/RedirectUrlValidator.php+11 −1
- typo3/sysext/felogin/Configuration/TCA/Overrides/fe_groups.php+2 −3
- typo3/sysext/felogin/Configuration/TCA/Overrides/fe_users.php+2 −3
- typo3/sysext/felogin/Configuration/TCA/Overrides/tt_content.php+73 −59
- typo3/sysext/felogin/Configuration/TCA/Overrides/tt_content_form_login.phpnew+80 −0
- typo3/sysext/felogin/Configuration/TsConfig/Page/Mod/Wizards/NewContentElement.tsconfig+9 −7
- typo3/sysext/felogin/Configuration/TsConfig/Page/PiBase/Mod/Wizards/NewContentElement.tsconfignew+11 −0
- typo3/sysext/felogin/Configuration/TypoScript/PiBase/constants.typoscriptnew+4 −0
- typo3/sysext/felogin/Configuration/TypoScript/PiBase/setup.typoscriptnew+104 −0
- typo3/sysext/felogin/Configuration/TypoScript/constants.typoscript+1 −1
- typo3/sysext/felogin/Configuration/TypoScript/setup.typoscript+3 −102
- typo3/sysext/felogin/Resources/Private/Language/Database.xlf+6 −0
- typo3/sysext/felogin/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/felogin/Resources/Private/Partials/RenderLabelOrMessage.htmlnew+16 −0
Show 7 more files
- typo3/sysext/felogin/Resources/Private/Templates/Login/Login.htmlnew+51 −0
- typo3/sysext/felogin/Resources/Private/Templates/Login/Logout.htmlnew+26 −0
- typo3/sysext/felogin/Resources/Private/Templates/Login/Overview.htmlnew+9 −0
- typo3/sysext/felogin/Tests/Functional/Tca/ContentVisibleFieldsTest.php+11 −2
- typo3/sysext/felogin/Tests/Unit/Controller/LoginControllerTest.phpnew+313 −0
- typo3/sysext/felogin/ext_localconf.php+53 −16
- typo3/sysext/felogin/ext_tables.phpnew+17 −0
Review log 24
-
TYPO3com uploaded patch set 1 07/09/19, 07:58
-
TYPO3com voted on patch set 1 V -1 07/09/19, 07:58 Completed build in 11s on Tue, 9 Jul, 09:58 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34854
-
Oliver Klee commented on patch set 1 CR -1 07/09/19, 09:50
I strongly recommend splitting this into several change requests: One for the reformatting, one for adding type declarations and making some functions static, and one for each self-contained refactoring. Otherwise, this will be really hard to review, and if something breaks, we cannot revert only the offending change. -
Anja Leichsenring abandoned the change 07/09/19, 11:54
misguided hubspot push, went to the wrong project