Review main Abandoned

61239[Task] reformat and optimize code

TYPO3com CR 0 V 0 Expert +1187 −195 updated 07/09/19, 11:54

Commit message

removes some code smells and refactors some wrong formatted code

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 27

Show 7 more files

Review log 24

  1. TYPO3com uploaded patch set 1 07/09/19, 07:58

  2. TYPO3com voted on patch set 1 V -1 07/09/19, 07:58 Completed build in 11s on Tue, 9 Jul, 09:58 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34854

  3. Oliver Klee commented on patch set 1 CR -1 07/09/19, 09:50

    I strongly recommend splitting this into several change requests: One for the reformatting, one for adding type declarations and making some functions static, and one for each self-contained refactoring. Otherwise, this will be really hard to review, and if something breaks, we cannot revert only the offending change.
  4. Anja Leichsenring abandoned the change 07/09/19, 11:54

    misguided hubspot push, went to the wrong project