Review main Merged

61246[TASK] Hook up ContainerInterface in backend route dispatcher

Benjamin Franzke CR +2 V +2 Normal +139 −26 updated 07/13/19, 17:34

Commit message

Transform InfoModuleController and it's dependency ModuleTemplate
into a symfony manageed services  to retrieve dependencies from
symfony instead of GeneralUtility::makeInstance.
ModuleTemplate is a prototype and is therefore marked shared: false.
It is marked public: true so legacy calls to
GeneralUtility::makeInstance(ModuleTemplate::class) resort to the
container and properly inject dependencies.

Also add a backend.controller symfony tag, to be universally
applied for backend controllers. This tag automatically configures
the controller to be publicly available from $container->get()
which allows the route dispatcher to lazily instantiate
the controller.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7