61277[TASK] Make Redis connectors compatible with PHP redis version 5
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Susi Moog +1
-
Verified V +2 Done
- Frank Nägler +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1822
-
Markus Klein uploaded patch set 1 07/12/19, 09:14
-
TYPO3com voted on patch set 1 V +1 07/12/19, 09:26 Completed build in 11m 58s on Fri, 12 Jul, 11:26 AM Test Summary: 46978 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34949
-
Benni Mack commented on patch set 1 07/12/19, 09:52
-
Markus Klein commented on patch set 2 07/12/19, 10:25
Published edit on patch set 1. -
Markus Klein commented on patch set 2 07/12/19, 10:26
RedisBackend.php:41ReplyDone -
TYPO3com voted on patch set 2 V +1 07/12/19, 10:36 Completed build in 10m 49s on Fri, 12 Jul, 12:36 PM Test Summary: 46976 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34955
-
Tymoteusz Motylewski commented on patch set 2 07/15/19, 08:45
RedisSessionBackend.php:306mGet -
Markus Klein commented on patch set 2 07/15/19, 08:58
RedisSessionBackend.php:306ReplyRight, but now we have a problem. in v4 it is mget, in v5 it its mGet :-( -
Tymoteusz Motylewski commented on patch set 2 07/15/19, 09:16
RedisSessionBackend.php:306Replymethod names are case insensitive in php, so I would keep v5 version (which should work with v4 too). But the change should be tested with both versions. -
Markus Klein commented on patch set 2 07/15/19, 09:42
RedisSessionBackend.php:306Reply Unresolved> method names are case insensitive in php They are still? ;-) I thought that was changed with PHP 7 or so. But lucky we are then. -
Markus Klein commented on patch set 3 07/21/19, 22:40
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V +1 07/21/19, 22:53 Completed build in 12m 49s on Mon, 22 Jul, 12:52 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35255
-
Jonas Eberle commented on patch set 3 V +1 CR +1 07/31/19, 11:42
Tested with PHP 7.3 and ext-redis 4.3.0 and cross-checked with phpredis docs -
Andreas Kienast voted on patch set 3 CR +1 07/31/19, 13:51
-
Frank Nägler commented on patch set 3 V +1 CR -1 08/07/19, 13:05
wait of confirmation by Susi -
Frank Nägler commented on patch set 3 08/07/19, 13:23
@Markus can you also adjust the existing tests? I found at least RedisBackendTest which use delete() -
Markus Klein commented on patch set 3 08/07/19, 13:40
Wow... good finding. will take care -
Markus Klein uploaded patch set 4 08/07/19, 13:53
-
TYPO3com voted on patch set 4 V +1 08/07/19, 14:04 Completed build in 10m 31s on Wed, 7 Aug, 02:04 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35628
-
Susi Moog voted on patch set 4 V +1 CR +1 08/07/19, 15:22
-
Frank Nägler voted on patch set 4 V +2 CR +2 08/07/19, 15:23
-
Frank Nägler merged patch set 5 08/07/19, 15:24
RedisBackend.php:41