Review main Merged

61278[BUGFIX] Dispatch native `change` event in TBE_EDITOR.fieldChanged()

Andreas Kienast CR +2 V +2 Easy +2 −1 updated 07/14/19, 10:57

Commit message

With #87324 some code of FormEngine was moved into separated modules. In
the very same patch, most of the code was rewritten to use native
JavaScript as much as possible. However, with this change,
`TBE_EDITOR.fieldChanged()` was partially broken as it uses jQuery's
`triggerHandler` method to trigger a specific event. Events that are
registered via jQuery's `on()` method work fine, but the approach is
incompatible with JavaScript's native `addEventListener()` introduced
in the mentioned change.

As a quick fix, `TBE_EDITOR.fieldChanged()` now triggers the same event
for native JavaScript code via `dispatchEvent()`.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1