Review main Merged Breaking

61284[!!!][TASK] Remove cHash calculation in indexed search

Benni Mack CR +2 V +2 Normal +115 −123 updated 07/13/19, 12:20

Commit message

cHash is now added automatically when a URL is generated.
The relevant query parameters when indexing
are stored in "static_page_arguments", which allows
to remove the database field "cHashParams".

Therefor it is not necessary anymore to configure if
cHash should be taken into account when creating
a configuration for indexed search.

Instead, when linking to a page on a search result,
the page arguments are added. In addition, when
pages are indexed, only the static page arguments
are evaluated.

Debug Information when indexing is also adding
data more sensibly via json_encode/decode.

Effectively, this means that specific handling
for cHash resolving is fully removed from
EXT:indexed_search.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 20