Review main Merged

61285[BUGFIX] Remove native header() call in DocumentTemplate

Benni Mack CR +2 V +2 Easy +0 −1 updated 07/13/19, 20:14

Commit message

In DocumentTemplate there is always one header call
to define that everything is HTML and UTF-8.

Since we do PSR-7 in Backend Context, this should be handled
by the Response object, which we already do.

This should normally be a bugfix for existing stable versions,
although I'm very unsure on how this could affect any side-effects
where extensions rely on this behavior for years (!) already, so
this is master-only.

OTOH this change should not affect anything in regular BE
modules as they work with PSR-7 since TYPO3 v7 already.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1