Review main Merged Breaking

61286[!!!][TASK] Remove database fields related to CSS Styled Content

Benni Mack CR +2 V +2 Normal +49 −32 updated 07/15/19, 09:50

Commit message

The following database fields from "tt_content" have been removed:

* tt_content.spaceBefore (now used via space_before_class)
* tt_content.spaceAfter (now used via space_after_class)

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 68

  1. Benni Mack uploaded patch set 1 07/13/19, 15:33

  2. TYPO3com voted on patch set 1 V +1 07/13/19, 15:44 Completed build in 10m 44s on Sat, 13 Jul, 05:44 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35002

  3. Riccardo De Contardi commented on patch set 1 07/13/19, 15:45

    if `accessibility_title`, `accessibility_bypass` and `accessibility_bypass_text` are going to be removed, then https://forge.typo3.org/issues/75597 is going to be considered obsolete?
  4. Benni Mack uploaded patch set 2 07/13/19, 16:30

  5. TYPO3com voted on patch set 2 V +1 07/13/19, 16:44 Completed build in 11m 09s on Sat, 13 Jul, 06:44 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35006

  6. Daniel Goerz voted on patch set 2 V +1 CR +1 07/13/19, 20:10

  7. Frank Nägler voted on patch set 2 V +2 CR +2 07/15/19, 09:50

  8. Frank Nägler merged patch set 3 07/15/19, 09:50