Review main Merged Breaking

61295[!!!][TASK] Remove POST option from typolink.addQueryString.method

Oliver Hader CR +2 V +2 Hard +184 −203 updated 07/21/19, 08:14

Commit message

Setting `addQueryString.method` of typolink could be used like shown
below in order to transform HTTP POST parameters into according GET
parameters.

    typolink {
        parameter = 123
        addQueryString = 1
        addQueryString.method = POST
    }

In terms of correctly using HTTP verbs it's bad practise in general
to treat GET and POST equally, besides that documentation already
mentioned potential side-effects like accidentally exposing sensitive
data submitted via POST to proxies or log files.

That's why values POST, GET,POST and POST,GET are not allowed anymore
for `typolink.addQueryString.method`. Maintaining functionality - if
required at all - has to be done using domain specific logic in
according controllers or middleware implementations.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 9