61306[!!!][TASK] DatabaseRecordList: Remove unused code
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Markus Klein +1
- Riny van Tiggelen +1
-
Verified V +2 Done
- Georg Ringer +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/master/Breaking-88779-RecordListRemoveUnusedCode.rst8new+41 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+43 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+25 −0
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php4+5 −266
Review log 2029
Show 34 earlier messages
-
Daniel Windloff uploaded patch set 1 07/16/19, 09:04
-
TYPO3com voted on patch set 1 V +1 07/16/19, 09:14 Completed build in 10m 46s on Tue, 16 Jul, 11:14 AM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35076
-
Daniel Windloff uploaded patch set 2 07/16/19, 09:34
-
Daniel Windloff uploaded patch set 3 07/16/19, 09:41
-
TYPO3com voted on patch set 2 V -1 07/16/19, 09:48 Completed build in 13m 40s on Tue, 16 Jul, 11:48 AM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35077
-
TYPO3com voted on patch set 3 V -1 07/16/19, 09:55 Completed build in 14m 28s on Tue, 16 Jul, 11:55 AM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35079
-
Daniel Windloff uploaded patch set 4 07/16/19, 10:00
-
TYPO3com voted on patch set 4 V +1 07/16/19, 10:12 Completed build in 12m 15s on Tue, 16 Jul, 12:12 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35083
-
Mathias Brodala commented on patch set 4 07/16/19, 10:17
DatabaseRecordList.php:3906Same here. -
Daniel Windloff uploaded patch set 5 07/16/19, 11:08
-
Daniel Windloff commented on patch set 5 07/16/19, 11:09
DatabaseRecordList.php:3883ReplyDoneDatabaseRecordList.php:3906ReplyDone -
TYPO3com voted on patch set 5 V +1 07/16/19, 11:21 Completed build in 12m 42s on Tue, 16 Jul, 01:21 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35084
-
Oliver Klee voted on patch set 5 CR +1 07/16/19, 12:23
-
Daniel Windloff uploaded patch set 6 07/18/19, 13:21
-
Daniel Windloff uploaded patch set 7 07/18/19, 13:22
-
Oliver Klee voted on patch set 7 CR +1 07/18/19, 13:24
-
TYPO3com voted on patch set 6 V +1 07/18/19, 13:35 Completed build in 14m 04s on Thu, 18 Jul, 03:35 PM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35170
-
TYPO3com voted on patch set 7 V +1 07/18/19, 13:37 Completed build in 14m 14s on Thu, 18 Jul, 03:37 PM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35171
-
Georg Ringer commented on patch set 7 CR -1 07/18/19, 19:16
Breaking-88779-RecordListRemoveUnusedCode.rst:12have beenBreaking-88779-RecordListRemoveUnusedCode.rst:20have beenBreaking-88779-RecordListRemoveUnusedCode.rst:33the mentioned methodsBreaking-88779-RecordListRemoveUnusedCode.rst:41this is now FullyScanned isnt it? -
Daniel Windloff uploaded patch set 8 07/19/19, 07:01
-
Daniel Windloff commented on patch set 8 07/19/19, 07:02
Breaking-88779-RecordListRemoveUnusedCode.rst:12ReplyDoneBreaking-88779-RecordListRemoveUnusedCode.rst:20ReplyDoneBreaking-88779-RecordListRemoveUnusedCode.rst:33ReplyDoneBreaking-88779-RecordListRemoveUnusedCode.rst:41ReplyDone -
TYPO3com voted on patch set 8 V +1 07/19/19, 07:12 Completed build in 10m 48s on Fri, 19 Jul, 09:12 AM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35183
-
Daniel Windloff uploaded patch set 9 07/19/19, 08:47
-
Daniel Windloff commented on patch set 9 07/19/19, 08:48
Resolved merge conflict -
TYPO3com voted on patch set 9 V +1 07/19/19, 09:03 Completed build in 14m 50s on Fri, 19 Jul, 11:03 AM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35192
-
Markus Klein voted on patch set 9 V +1 CR +1 07/19/19, 09:42
-
Riny van Tiggelen voted on patch set 9 CR +1 07/19/19, 09:45
-
Georg Ringer voted on patch set 9 V +2 CR +2 07/19/19, 10:41
-
Georg Ringer merged patch set 10 07/19/19, 10:41
DatabaseRecordList.php:3883