Review main Abandoned

61308[BUGFIX] Foreign language records should not be loaded

Jonas Schwabe CR 0 V 0 Normal +45 −13 updated 09/23/20, 15:05

Commit message

This fixes a bug in the extbase DB backend that occured when:
a) The language used to fetch records was 0 (default language)
b) A record X that has a different language was fetched
   (e.g. as part of a relation)
c) The language parent of X was also fetched

The parent record has language 0 by definition and is therefore
the record that should be returned, as the current language is also 0.

To allow relations that do not refer directly to the default language
record, extbase sets the record language to 0 and let the core handle
the language overlay. If the current language is 0 as well the record
is returned instead of overlayed (as it looks like being in the correct
language already). This leads to foreign language records being
returned which is not desired behavior.

To fix this an additional check was added to make sure that the current
language is not 0 - in this case a language overlay is not neccessary
at all and should not be done to prevent the described behavior.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3