61350[TASK] Remove special TSFE handling in FileCollector
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Georg Ringer +1
- Oliver Klee +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1215
-
Benni Mack uploaded patch set 1 07/25/19, 06:12
-
TYPO3com voted on patch set 1 V +1 07/25/19, 06:23 Completed build in 10m 37s on Thu, 25 Jul, 08:23 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35314
-
Benni Mack updated the commit message in patch set 2 07/30/19, 07:38
-
TYPO3com voted on patch set 2 V +1 07/30/19, 07:48 Completed build in 09m 32s on Tue, 30 Jul, 09:48 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35379
-
Tymoteusz Motylewski commented on patch set 2 07/30/19, 09:28
do you have any idea why it was implemented that way? This looks like a workaround for some edge cases? -
Oliver Klee voted on patch set 2 CR +1 07/30/19, 10:00
-
Björn Jacob commented on patch set 2 07/30/19, 10:41
Unresolved
The commit msg is quite difficult to read. Here is my proposal: "The FileCollector is e.g. used for resolving references in the FILES cObject. The check for TSFE can be removed since the ->getFileReferences functionality should be used at any time, as the functionality always handles overlays depending on the $referenceRecord given." What do you think? -
Georg Ringer voted on patch set 2 V +1 CR +1 07/30/19, 14:54
-
Benni Mack updated the commit message in patch set 3 07/31/19, 04:47
-
Benni Mack commented on patch set 3 07/31/19, 04:49
> Patch Set 2: > > do you have any idea why it was implemented that way? This looks like a workaround for some edge cases? Sure. We created the FileCollector back in 6.x when FAL was introduced to separate this functionality from the FILES cObject and from Fluid DataProcessors (otherwise I would have copied it to the new DataProcessor back then). This happened a lot of times when introducing DataProcessors. However in this case, we just did it 1:1 as it was in the FILES cObject (functionality-wise), and since TSFE was always required but possibly done via eID scripts, this could fail. however, as we introduced Aspects and decoupled sys_page from TSFE, a new sys_page object can be created at any time with the current context, while keeping it re-usable. -
TYPO3com voted on patch set 3 V +1 07/31/19, 05:16 Completed build in 14m 45s on Wed, 31 Jul, 05:16 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35402
-
Georg Ringer voted on patch set 3 V +1 CR +1 07/31/19, 06:45
-
Oliver Klee voted on patch set 3 CR +1 07/31/19, 09:16
-
Anja Leichsenring voted on patch set 3 V +2 CR +2 08/02/19, 12:01
-
Anja Leichsenring merged patch set 4 08/02/19, 12:01