Review 9.5 Merged

61364[BUGFIX] Ensure all files in a directory are deleted

Susi Moog CR +2 V +2 Easy +13 −3 updated 08/05/19, 12:52

Commit message

The function readdir may skip files inside a directory when
its content is changed, like a file being deleted. This can
cause not all files inside being deleted

To avoid this, we collect all entries inside a directory and
close the read descriptor before deleting all entries inside.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Susi Moog commented on patch set 1 08/03/19, 13:10

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 08/03/19, 13:28 Completed build in 17m 53s on Sat, 3 Aug, 01:28 PM Test Summary: 9 of 50997 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-951

  3. Frank Nägler voted on patch set 1 CR +1 08/05/19, 12:47

  4. TYPO3com voted on patch set 1 V +1 08/05/19, 12:50 Completed build in 23h 58m 17s on Mon, 5 Aug, 12:50 PM Test Summary: 50529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-951

  5. Frank Nägler voted on patch set 1 V +1 08/05/19, 12:52

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 08/05/19, 12:52

  7. Andreas Kienast merged patch set 2 08/05/19, 12:52