Review main Merged

61404[TASK] Add test case for reverse proxy configuration

Jonas Eberle CR +2 V +2 Easy +13 −1 updated 09/04/19, 14:19

Commit message

The case covers given HTTP_HOST and HTTP_X_FORWARDED_HOST with
a configuration for an (intransparent) proxy.

As some reverse proxies can be configured to have a rewritten HTTP_HOST
(usually some internal name that matches the virtual host config on the
webserver) I wondered if I can safely assume that TYPO3 handles that.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Jonas Eberle +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Jonas Eberle +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1216

  1. Jonas Eberle uploaded patch set 1 08/02/19, 14:58

  2. Jonas Eberle updated the commit message in patch set 2 08/02/19, 14:58

  3. Jonas Eberle updated the commit message in patch set 3 08/02/19, 15:02

  4. TYPO3com voted on patch set 1 V -1 08/02/19, 15:09 Completed build in 11m 09s on Fri, 2 Aug, 03:09 PM Test Summary: 21 of 47538 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35476

  5. TYPO3com voted on patch set 2 V -1 08/02/19, 15:10 Completed build in 11m 34s on Fri, 2 Aug, 03:10 PM Test Summary: 16 of 47538 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35477

  6. TYPO3com voted on patch set 3 V +1 08/02/19, 15:13 Completed build in 10m 59s on Fri, 2 Aug, 03:13 PM Test Summary: 47178 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35478

  7. Markus Klein voted on patch set 3 CR +1 08/02/19, 15:32

  8. Marc von Schalscha voted on patch set 3 CR +1 08/02/19, 20:10

  9. Benjamin Franzke commented on patch set 4 09/04/19, 09:06

    Published edit on patch set 3.
  10. Benjamin Franzke voted on patch set 4 V +1 CR +1 09/04/19, 09:06

  11. TYPO3com voted on patch set 4 V +1 09/04/19, 09:18 Completed build in 11m 50s on Wed, 4 Sep, 09:18 AM Test Summary: 47258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36043

  12. Jonas Eberle commented on patch set 4 09/04/19, 11:07

    The space was actually not by accident there. It is on other tests already and i found it clever to test for error tolerance in probable inconsistencies of transmitted values
  13. Benjamin Franzke commented on patch set 4 09/04/19, 11:24

    Hm, I see, I actually contemplated that you may have added that space on purpose and thought about leaving that in, but on the other hand we have getRemoteAddressReturnsExpectedValueDataProvider() which is intended to cover these cases. Personally I'd like to avoid introducing new tests/testdata, which test behaviour that they do not describe. What I mean: the space would have been fine, when the testdata description would have included " with non-trimmed reverseProxyIp", otherwise it really looks like a typo.
  14. Jonas Eberle commented on patch set 4 V +1 CR +1 09/04/19, 11:36

    > getRemoteAddressReturnsExpectedValueDataProvider() which is intended to cover these cases. Yes, agreed. I think I did not see that all the non-trimmed values before where in that data provider. I thought it was kind of arbitrarily spread all over the place to add randomness...
  15. Benjamin Franzke voted on patch set 4 V +2 CR +2 09/04/19, 14:19

  16. Benjamin Franzke merged patch set 5 09/04/19, 14:19