Review TYPO3_8-7 Merged

61455[BUGFIX] Make redis pconnect calls unique

Frank Nägler CR +2 V +2 Easy +4 −2 updated 08/07/19, 12:34

Commit message

By using the persistent_id parameter of the redis->pconnect
method, we ensure that the connection is not shared between
multiple Redis*Backends connecting to the same Redis server.

Omitting the persistent_id causes the same connection to be reused
whenever another Redis*Backend is created, whereby the last
connection selects the database to use for the connection, effectively
causing all Redis*Backends to write to the same database.

The RedisSessionBackend uses the pconnect method by default and
therefore requires this fix in order to distinguish FE and BE
backends correctly, if both are stored within a Redis database.

The pconnect is optional for the cache RedisBackend, but we still
use the database number now for the persistent_id parameter.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2