Review main Merged

61566[FEATURE] Render fieldControl for SelectSingleElement

Philipp Parzer CR +2 V +2 Easy +42 −0 updated 01/25/20, 13:24

Commit message

The missing rendering for the fieldControl option for
`SelectSingleElements` was added.
It is now possible to use the fieldControl option for
SelectSingleElements to add nodes and wizards.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1116

  1. Philipp Parzer uploaded patch set 1 08/28/19, 09:02

  2. TYPO3com voted on patch set 1 V +1 08/28/19, 09:17 Completed build in 14m 31s on Wed, 28 Aug, 09:17 AM Test Summary: 47236 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35882

  3. Susi Moog voted on patch set 1 CR +1 09/11/19, 13:17

  4. Andreas Kienast commented on patch set 1 CR -1 09/11/19, 13:20

    The patch is marked as bugfix, but contains a Feature.rst.
  5. Susi Moog updated the commit message in patch set 2 09/11/19, 13:26

  6. TYPO3com voted on patch set 2 V +1 09/11/19, 13:45 Completed build in 13m 39s on Wed, 11 Sep, 01:45 PM Test Summary: 47515 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36316

  7. Steffen Frese voted on patch set 2 CR +1 10/10/19, 06:35

  8. Georg Ringer commented on patch set 2 CR -1 10/10/19, 06:45

    Feature-89032-RenderFieldControlForSelectSingleElement.rst:18 Unresolved

    please add an example so everybody knows what it is about, thx
  9. Susi Moog commented on patch set 2 10/26/19, 09:35

    This is the same topic / issue as https://review.typo3.org/c/Packages/TYPO3.CMS/+/59651 - could we combine both patches?
  10. Susi Moog uploaded patch set 3 01/25/20, 13:00

  11. TYPO3com voted on patch set 3 V -1 01/25/20, 13:10 Completed build in 09m 44s on Sat, 25 Jan, 01:10 PM Test Summary: 70576 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40218

  12. Andreas Kienast voted on patch set 3 V +1 CR +1 01/25/20, 13:14

  13. TYPO3com commented on patch set 3 01/25/20, 13:14 Completed build in 23m 53s on Sat, 25 Jan, 01:14 PM Test Summary: 5 of 71032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40218

  14. TYPO3com voted on patch set 3 V +1 01/25/20, 13:23 Completed build in 47m 09s on Sat, 25 Jan, 01:23 PM Test Summary: 70582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40218

  15. Susi Moog voted on patch set 3 V +2 CR +2 01/25/20, 13:24

  16. Susi Moog merged patch set 4 01/25/20, 13:24