Review main Merged

61576[BUGFIX] Support multiple env vars per line in Yaml

Susi Moog CR +2 V +2 Normal +39 −13 updated 09/04/19, 08:54

Commit message

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Susi Moog +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1626

Show 1 earlier messages
  1. Susi Moog uploaded patch set 1 08/29/19, 13:30

  1. TYPO3com voted on patch set 1 V +1 08/29/19, 13:40 Completed build in 09m 19s on Thu, 29 Aug, 01:40 PM Test Summary: 47244 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35924

  2. Andreas Kienast uploaded patch set 2 09/02/19, 09:53

  3. Andreas Kienast uploaded patch set 3 09/02/19, 09:57

  4. TYPO3com voted on patch set 2 V -1 09/02/19, 10:04 Completed build in 10m 22s on Mon, 2 Sep, 10:04 AM Test Summary: 5 of 47559 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35986

  5. TYPO3com voted on patch set 3 V -1 09/02/19, 10:08 Completed build in 10m 54s on Mon, 2 Sep, 10:08 AM Test Summary: 4 of 47369 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35987

  6. Andreas Kienast uploaded patch set 4 09/02/19, 10:13

  7. Susi Moog commented on patch set 4 09/02/19, 10:17

    This change is ready for review.
  8. TYPO3com voted on patch set 4 V +1 09/02/19, 10:24 Completed build in 10m 12s on Mon, 2 Sep, 10:24 AM Test Summary: 47256 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35988

  9. Andreas Kienast uploaded patch set 5 09/02/19, 10:31

  10. Andreas Kienast updated the commit message in patch set 6 09/02/19, 10:33

  11. TYPO3com voted on patch set 5 V +1 09/02/19, 10:42 Completed build in 11m 17s on Mon, 2 Sep, 10:42 AM Test Summary: 47264 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35989

  12. TYPO3com voted on patch set 6 V +1 09/02/19, 10:45 Completed build in 12m 14s on Mon, 2 Sep, 10:45 AM Test Summary: 47264 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35990

  13. Susi Moog commented on patch set 6 09/02/19, 11:04

    YamlFileLoaderTest.php:197 Unresolved

    can we add a "all env vars undefined" test case?
  14. Andreas Kienast uploaded patch set 7 09/02/19, 11:18

  15. TYPO3com voted on patch set 7 V -1 09/02/19, 11:29 Completed build in 10m 49s on Mon, 2 Sep, 11:29 AM Test Summary: 47040 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35991

  16. TYPO3com voted on patch set 7 V +1 09/02/19, 11:38 Completed build in 31m 33s on Mon, 2 Sep, 11:38 AM Test Summary: 47268 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35991

  17. Guido Schmechel commented on patch set 7 09/03/19, 08:12

    Can we have this for 9.5, too?
  18. Andreas Kienast updated the commit message in patch set 8 09/03/19, 08:41

  19. TYPO3com voted on patch set 8 V -1 09/03/19, 08:51 Completed build in 09m 48s on Tue, 3 Sep, 08:51 AM Test Summary: 1 of 47633 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36011

  20. TYPO3com voted on patch set 8 V +1 09/03/19, 10:18 Completed build in 1h 47m 04s on Tue, 3 Sep, 10:18 AM Test Summary: 47274 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36011

  21. Susi Moog voted on patch set 8 V +1 CR +1 09/04/19, 07:24

  22. Benjamin Franzke voted on patch set 8 CR +1 09/04/19, 07:44

  23. Benjamin Franzke voted on patch set 8 V +1 09/04/19, 07:47

  24. Susi Moog voted on patch set 8 V +2 CR +2 09/04/19, 08:54

  25. Susi Moog merged patch set 9 09/04/19, 08:54