Review main Abandoned

61587[WIP][TASK] Introduce constants for aspect names

Oli Bartsch CR 0 V 0 Hard +258 −207 updated 12/13/19, 20:51

Commit message

This adds public constants for the names of all currently
existing aspects and replaces all occurrences with them.

As this is public API, besides the well known advantages
of constants (technically), this features some benefits such as:
- Reduction of the error rate due to typos
- Enable IDE support (autocompletion, search for occurrences, ...)
- Possibility to easily change a name on one central place

Note: The constants are added in the Context class as this is the
central point. It would be also possible to add them to the
corresponding Aspect classes. But having them in a central point
provides more clarity.

Possible TODOs:
- Also update rst files
- Also introduce constants for aspect property names

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 64

Show 44 more files