Review 9.5 Merged

61606[TASK] Add default value to unused parameter in addPItoST43()

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 09/09/19, 15:19

Commit message

The second argument of ExtensionManagementUtility::addPItoST43() has been
made obsolete with TYPO3 v8, but is still required when using the method.
This patch sets the default value of that argument to an empty string to
make the argument truly optional.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Benjamin Franzke commented on patch set 1 09/09/19, 13:49

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 09/09/19, 14:03 Completed build in 14m 14s on Mon, 9 Sep, 02:03 PM Test Summary: 50603 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1122

  3. TYPO3com voted on patch set 1 V +1 09/09/19, 14:34 Completed build in 12m 06s on Mon, 9 Sep, 02:34 PM Test Summary: 50612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1123

  4. Oliver Klee voted on patch set 1 CR +1 09/09/19, 14:59

  5. Benjamin Franzke voted on patch set 1 V +2 CR +2 09/09/19, 15:19

  6. Benjamin Franzke merged patch set 2 09/09/19, 15:19