Review main Merged

61671[BUGFIX] Keep workspace ID when discarding versioned records

Benni Mack CR +2 V +2 Hard +310 −264 updated 09/13/19, 11:45

Commit message

When a record was modified in a workspace, and then discarded, TYPO3 previously
set the t3ver_wsid to "0", which basically meant "we release it to live workspace
as a offline version with pid=-1".

However, this turns out to be ugly, as this information is then floating in live workspace,
without any information where this record was from.

Instead, "discarding versioned records" now keeps the t3ver_wsid=X, and just marks
the versioned record as "deleted" - or removes it completely if the database table
does not support to mark records as deleted.

As a result, there will be no records in live workspace anymore with "pid=-1" in the future
anymore. To remove any "old" discarded records, an upgrade wizard will follow
in a followup patch.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 50

Show 30 more files