Review main Merged

61702[BUGFIX] Disallow phpdocumentor/reflection-docblock >= 4.3.2

Andreas Kienast CR +2 V +2 Easy +11 −9 updated 09/13/19, 10:59

Commit message

The package phpdocumentor/reflection-docblock introduces major regressions
starting with 4.3.2 that leads to getting nullable compound types (e.g.
`?string|int`) parsed completely wrong, which currently also breaks in
symfony/property-info.

Also, it became stricter about type annotations which currently collides
with Fluid.

For this reason, the package is marked as conflicting starting with
version 4.3.2.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3