Review main Merged

61786[FEATURE] Show broken links only in editable fields

Sybille Peters CR +2 V +2 Expert +1429 −26 updated 02/24/20, 14:03

Commit message

Linkvalidator should show broken links only in the list of broken links,
if current backend user has edit access to the field. This way
the editor will no longer get an error message on trying to
edit records he has no permission to edit.

Whether the editor has access depends on a number of factors.

We check the following:

* The current permissions of the page. For editing the page, the editor
  must have Permission::PAGE_EDIT, for editing content
  Permission::CONTENT_EDIT must be available
* The user has write access to the table. We check if the table
  is in 'tables_modify' for the group(s)
* The user has write access to the field. We check if the field
  is an exclude field. If yes, it must be included in
  'non_exclude_fields' for the group(s).
* The user has write permission for the language of the record
* For all tables with type fields: The type is in list of explicitly
  allowed values for authMode (or not explicitly denied depending on
  the setting).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 18