Review main Merged

61799[BUGFIX] Decode tag attributes during HTML parsing

Helmut Hummel CR +2 V +2 Easy +21 −10 updated 11/09/19, 15:01

Commit message

When parsing HTML in parsefunc, we need to make sure
that the attributes that are extracted for further processing
are properly HTML decoded, as per definition they are encoded in
the HTML being parsed.

At the same time we revert a decode that was applied in ExternalUrlLinkBuilder,
as this is the wrong place to handle HTML decoding, as the link builder
is as well called with data from other contexts (TypoScript, data from link fields)
that must not have the URL HTML encoded.

This fix is required to allow email links to add subject and body arguments like:
test@foo.test?subject=foo%20bar&body=baz

and not have the ampersand in the url double encoded when generating links
from RTE content.

Additionally we need to properly encode the masked value for the JavaScript
URI, to prevent browsers from url decoding wrong values.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 6