Review main Merged

61871[TASK] Replace FrontendCacheInterface

TYPO3com CR +2 V +2 Easy +3 −3 updated 10/07/19, 12:58

Commit message

Replace inexistent FrontendCacheInterface by FrontendInterface

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 813

  1. TYPO3com uploaded patch set 1 10/01/19, 09:02

  2. TYPO3com voted on patch set 1 V -1 10/01/19, 09:13 Completed build in 10m 49s on Tue, 1 Oct, 09:13 AM Test Summary: 37701 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36988

  3. TYPO3com voted on patch set 1 V +1 10/07/19, 11:21 Completed build in 23m 09s on Mon, 7 Oct, 11:21 AM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37096

  4. Daniel Siepmann uploaded patch set 2 10/07/19, 11:38

  5. Sascha Rademacher voted on patch set 2 V +1 CR +1 10/07/19, 11:39

  6. Daniel Siepmann voted on patch set 2 V +1 CR +1 10/07/19, 11:40

  7. Frank Nägler commented on patch set 2 CR -1 10/07/19, 11:46

    Feature-89054-ProvideCoreCacheFrontendsViaDependencyInjection.rst:50 Unresolved

    that is also wrong and syntactically broken. there is a backtick too much.
  8. Jan Stockfisch commented on patch set 3 10/07/19, 11:50

    Published edit on patch set 2.
  9. TYPO3com voted on patch set 2 V -1 10/07/19, 11:50 Completed build in 12m 12s on Mon, 7 Oct, 11:50 AM Test Summary: 47475 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37098

  10. TYPO3com voted on patch set 3 V +1 10/07/19, 12:08 Completed build in 17m 43s on Mon, 7 Oct, 12:08 PM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37100

  11. Jörg Bösche voted on patch set 3 V +1 CR +1 10/07/19, 12:33

  12. Frank Nägler voted on patch set 3 V +2 CR +2 10/07/19, 12:58

  13. Frank Nägler merged patch set 4 10/07/19, 12:58