Review main Merged

62033[BUGFIX] Use GeneralUtility for initialization of PageRenderer

Daniel Goerz CR +2 V +2 Easy +4 −11 updated 10/21/19, 13:03

Commit message

The PageRenderer is set via GeneralUtility::setSingletonInstance()
by TSFE. This circumvents the DI concept and has to be removed in
the long term. It leads to the situation where makeInstance()
returns a different instance of the PageRenderer than the global DI
does.

To restore the functionality we instanciate the PageRenderer with
makeInstance() for now and will follow-up with another patch later
on to remove setSingletonInstance() usages outside of tests.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2