Review main Merged

62076[BUGFIX] Set correct default value for TSFE properties

Georg Ringer CR +2 V +2 Easy +2 −2 updated 10/25/19, 12:57

Commit message

As the properties rootLine and page of TSFE are arrays, the default
value must be set to an empty array instead of an string to avoid
warnings if the TSFE is bootstraped but no rootline has been defined.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Georg Ringer uploaded patch set 1 10/23/19, 07:18

  2. Georg Ringer commented on patch set 1 10/23/19, 07:18

    This change is ready for review.
  3. Richard Haeser voted on patch set 1 V +1 CR +1 10/23/19, 07:21

  4. TYPO3com voted on patch set 1 V +1 10/23/19, 07:29 Completed build in 10m 53s on Wed, 23 Oct, 07:29 AM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37483

  5. Benni Mack voted on patch set 1 V +2 CR +2 10/23/19, 07:38

  6. Benni Mack merged patch set 2 10/23/19, 07:38

  7. Markus Klein commented on patch set 2 V +1 CR +1 10/23/19, 07:46

    post votes, since I was too slow with my review. Validated all usages manually if any place relied on the '' default.
  8. Benni Mack commented on patch set 2 10/25/19, 12:17

    Please recheck - getPageAndRootlineWithDomain() does an is_array() check, which now jumps in an if() condition, which it _might_ have not done before.
  9. Markus Klein commented on patch set 2 10/25/19, 12:43

    > Patch Set 2: > > Please recheck - getPageAndRootlineWithDomain() does an is_array() check, which now jumps in an if() condition, which it _might_ have not done before. This is indeed a potential regression. If the rootline is an empty array now, we run into a pageNotFound condition.
  10. Markus Klein commented on patch set 2 10/25/19, 12:57