62076[BUGFIX] Set correct default value for TSFE properties
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
- Richard Haeser +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Klein +1
- Richard Haeser +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 910
-
Georg Ringer uploaded patch set 1 10/23/19, 07:18
-
Georg Ringer commented on patch set 1 10/23/19, 07:18
This change is ready for review. -
Richard Haeser voted on patch set 1 V +1 CR +1 10/23/19, 07:21
-
TYPO3com voted on patch set 1 V +1 10/23/19, 07:29 Completed build in 10m 53s on Wed, 23 Oct, 07:29 AM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37483
-
Benni Mack voted on patch set 1 V +2 CR +2 10/23/19, 07:38
-
Benni Mack merged patch set 2 10/23/19, 07:38
-
Markus Klein commented on patch set 2 V +1 CR +1 10/23/19, 07:46
post votes, since I was too slow with my review. Validated all usages manually if any place relied on the '' default. -
Benni Mack commented on patch set 2 10/25/19, 12:17
Please recheck - getPageAndRootlineWithDomain() does an is_array() check, which now jumps in an if() condition, which it _might_ have not done before. -
Markus Klein commented on patch set 2 10/25/19, 12:43
> Patch Set 2: > > Please recheck - getPageAndRootlineWithDomain() does an is_array() check, which now jumps in an if() condition, which it _might_ have not done before. This is indeed a potential regression. If the rootline is an empty array now, we run into a pageNotFound condition. -
Markus Klein commented on patch set 2 10/25/19, 12:57