Review main Merged

62095[TASK] Call static PHPUnit methods via self:: instead of $this->

Alexander Schnitzler CR +2 V +2 Impossible +10166 −10165 updated 10/24/19, 12:42

Commit message

Class \PHPUnit\Framework\TestCase provides many assertion methods
that can be called statically and dynamically in the context of
tests. Sebastian Bergmann states that neither using $this nor
self/static is right or wrong.

There are two reasons to use self/static however. First of all
IDE's like PhpStorm support code inspections that tell you to
not call static methods dynamically and therefore make your
code look like a christmas tree. Secondly, there is a rule
for php-cs-fixer that can take care of the initial change
and which helps sticking to one specific format, unifying
the code style overall.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 796

Show 776 more files