Review main Abandoned

62123[FEATURE] Add category processor to enhance records with a category tree

Jo Hasenau CR 0 V 0 Hard +280 −0 updated 11/09/26, 09:52

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1419

  1. Jo Hasenau uploaded patch set 1 10/26/19, 09:08

  2. TYPO3com voted on patch set 1 V +1 10/26/19, 09:21 Completed build in 13m 00s on Sat, 26 Oct, 09:21 AM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37772

  3. Oli Bartsch commented on patch set 1 10/27/19, 22:47

    Feature-82010-AddCategoryTreeProcessor.rst:5

    This is obviously not the correct title ;)

    CategoryTreeProcessor.php:186

    Not necessary as this is the default value.

    CategoryTreeProcessor.php:214

    Because we are sure that $data is always an array we can unhesitatingly drop the not empty check here.
  4. Jörg Bösche uploaded patch set 2 01/14/20, 11:05

  5. Jörg Bösche commented on patch set 2 01/14/20, 11:05

    Feature-82010-AddCategoryTreeProcessor.rst:5 Reply

    Done

    CategoryTreeProcessor.php:186 Reply

    Done

    CategoryTreeProcessor.php:214 Reply

    Done
  6. Jörg Bösche uploaded patch set 3 01/14/20, 11:13

  7. TYPO3com voted on patch set 2 V +1 01/14/20, 11:31 Completed build in 11m 46s on Tue, 14 Jan, 11:31 AM Test Summary: 69566 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39892

  8. TYPO3com voted on patch set 3 V -1 01/14/20, 11:46 Completed build in 26m 46s on Tue, 14 Jan, 11:46 AM Test Summary: 69566 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39893

  9. TYPO3com commented on patch set 3 01/14/20, 12:19 Completed build in 08m 02s on Tue, 14 Jan, 12:19 PM Test Summary: 69559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39897

  10. TYPO3com voted on patch set 3 V +1 01/22/20, 14:26 Completed build in 2h 23m 14s on Wed, 22 Jan, 02:26 PM Test Summary: 69566 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39897

  11. Anja Leichsenring voted on patch set 3 CR +1 02/13/20, 11:15

  12. Susi Moog commented on patch set 3 V -1 CR -1 02/21/20, 09:06

    - The name in the example rst is wrong (CategoryProcessor vs CategoryTreeProcessor). - The AbstractProcessor this class extends does not exist - The interface implemented here is not found (missing use statement)
  13. Jo Hasenau commented on patch set 3 02/29/20, 00:43

    This patch was supposed to be based on #62082 so that's why there are missing classes and interface
  14. Jo Hasenau commented on patch set 3 02/29/20, 00:44

  15. Susi Moog marked it work in progress 02/29/20, 18:20

  16. Susi Moog commented on patch set 3 02/29/20, 18:21

    as the other one is WIP and we have feature freeze, I set WIP here, too, so we get a cleaner list.
  17. Benni Mack wrote 11/29/21, 10:01

    Change destination moved from master to main
  18. Benni Mack updated the commit message in patch set 4 11/29/21, 13:16

  19. Georg Ringer abandoned the change 11/09/26, 09:52

    available via {page.record.categories} now