Review TYPO3_8-7 Merged

62130[BUGFIX] Use strict type checking for in_array() calls in JsonView

Susi Moog CR +2 V +2 Easy +31 −4 updated 10/30/19, 06:22

Commit message

If the JsonView traverses array with numeric indexes and an exclude
configuration is set, the first array element is now handled correctly.

The comparison of array index 0 with a string within in_array() yields
TRUE, hence the first element was skipped.

Review

  • Code review CR +2 Done
    • Susi Moog +2
  • Verified V +2 Done
    • Susi Moog +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 58

  1. Susi Moog uploaded patch set 1 10/28/19, 19:15

  2. TYPO3com voted on patch set 1 V -1 10/28/19, 19:15 Completed build in 25s on Mon, 28 Oct, 07:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3685

  3. Susi Moog uploaded patch set 2 10/28/19, 19:54

  4. TYPO3com voted on patch set 2 V -1 10/28/19, 20:06 Completed build in 11m 50s on Mon, 28 Oct, 08:06 PM Test Summary: 2 of 80764 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3686

  5. Susi Moog uploaded patch set 3 10/28/19, 20:09

  6. TYPO3com voted on patch set 3 V +1 10/28/19, 20:20 Completed build in 10m 50s on Mon, 28 Oct, 08:20 PM Test Summary: 80408 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3687

  7. Susi Moog commented on patch set 3 V +2 CR +2 10/30/19, 06:22

    straight backport
  8. Susi Moog merged patch set 4 10/30/19, 06:22