62161[BUGFIX] Avoid double escaping of opendocs menu entries
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Jörg Bösche +1
- Susi Moog +1
-
Verified V +2 Done
- Daniel Goerz +2
- Jörg Bösche +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 67
-
Felix Althaus uploaded patch set 1 10/30/19, 18:36
-
Felix Althaus commented on patch set 1 10/30/19, 18:40
-
TYPO3com voted on patch set 1 V +1 10/30/19, 18:46 Completed build in 10m 27s on Wed, 30 Oct, 06:46 PM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37873
-
Jörg Bösche commented on patch set 1 V +1 CR +1 01/16/20, 10:34
I'm absolutely fine with this patch. Verified on v10.3.0-dev. We should htmlspecialchars_decode the label in PHP, beacause of other classes / xclasses / ... can use this data and should not take care about security and decoding issues. Test scenario: - Activate opendocs extension - Edit a page and add HTML special characters to the title (e.g. &,",>,<) - Click "Open and Recently Used Documents" in top bar - If necessary close and reopen to refresh the title in the dropdown -
Susi Moog voted on patch set 1 V +1 CR +1 01/16/20, 10:46
-
Daniel Goerz voted on patch set 1 V +2 CR +2 01/16/20, 10:50
-
Daniel Goerz merged patch set 2 01/16/20, 10:50
OpendocsToolbarItem.php:178Unresolved