62225[BUGFIX] Use indexed menu item array for directory menu
Commit message
Review
-
Code review CR +2 Done
- Tobi Kretschmann +2
- Markus Klein +1
- Alexander Stehlik +1
-
Verified V +2 Done
- Tobi Kretschmann +2
- Markus Klein +1
- Alexander Stehlik +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 810
-
Susi Moog commented on patch set 1 11/09/19, 13:39
Cherry Picked from branch master. -
TYPO3com voted on patch set 1 V -1 11/09/19, 13:50 Completed build in 11m 16s on Sat, 9 Nov, 01:50 PM Test Summary: 50586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1480
-
TYPO3com voted on patch set 1 V +1 11/26/19, 17:25 Completed build in 3h 57m 42s on Tue, 26 Nov, 05:25 PM Test Summary: 50879 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1480
-
Tymoteusz Motylewski commented on patch set 1 11/26/19, 20:37
AbstractMenuContentObject.php:839In some places in the core we use an id like „mountrootUid_pageUid”. Maybe this can be considered there too? Or the key is not used at all? -
Alexander Stehlik commented on patch set 1 11/26/19, 22:29
AbstractMenuContentObject.php:839ReplyAs far as I can see the method is only called by makeMenu() which only uses the array values of the $menuItems array. The keys are totally ignored. And some menu types (like the list menu) already return an indexed array. Unfortunately I missed that there are other menu types using the page ID as array key. This would have been a chance to unify this. But on the other hand that would not be a bugfix I guess ;) -
Alexander Stehlik voted on patch set 1 V +1 CR +1 11/26/19, 22:34
-
Susi Moog commented on patch set 1 12/05/19, 15:23
AbstractMenuContentObject.php:839Reply Unresolved+ this is the backport, so I would not make further changes here. -
Markus Klein voted on patch set 1 V +1 CR +1 01/12/20, 16:20
-
Tobi Kretschmann voted on patch set 1 V +2 CR +2 01/14/20, 12:54
-
Tobi Kretschmann merged patch set 2 01/14/20, 12:54