Review main Merged

62244[BUGFIX] Unconfigured typeNums should result in 404 instead of 500 response

Benni Mack CR +2 V +2 Easy +33 −2 updated 11/22/19, 15:52

Commit message

Calling a URL with type=138 which is not configured should not result in
an "page unavailable" but a "page not found" (404) response.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 713

  1. Benni Mack uploaded patch set 1 11/07/19, 22:00

  2. TYPO3com voted on patch set 1 V -1 11/07/19, 22:09 Completed build in 09m 15s on Thu, 7 Nov, 10:09 PM Test Summary: 407 of 48243 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38089

  3. TYPO3com voted on patch set 1 V +1 11/09/19, 14:39 Completed build in 16h 48m 28s on Sat, 9 Nov, 02:39 PM Test Summary: 48145 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38089

  4. Benni Mack uploaded patch set 2 11/22/19, 14:00

  5. TYPO3com voted on patch set 2 V +1 11/22/19, 14:07 Completed build in 07m 31s on Fri, 22 Nov, 02:07 PM Test Summary: 48088 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38639

  6. Benni Mack updated the commit message in patch set 3 11/22/19, 14:08

  7. Benni Mack updated the commit message in patch set 4 11/22/19, 14:08

  8. TYPO3com voted on patch set 3 V +1 11/22/19, 14:16 Completed build in 07m 52s on Fri, 22 Nov, 02:16 PM Test Summary: 48088 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38640

  9. TYPO3com voted on patch set 4 V -1 11/22/19, 14:16 Completed build in 07m 49s on Fri, 22 Nov, 02:16 PM Test Summary: 1 of 48433 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38641

  10. TYPO3com voted on patch set 4 V +1 11/22/19, 14:19 Completed build in 18m 00s on Fri, 22 Nov, 02:19 PM Test Summary: 48088 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38641

  11. Oliver Hader voted on patch set 4 V +1 CR +1 11/22/19, 15:30

  12. Anja Leichsenring voted on patch set 4 V +2 CR +2 11/22/19, 15:52

  13. Anja Leichsenring merged patch set 5 11/22/19, 15:52