Review main Merged

62248[TASK] Do not add target attribute if lightbox is enabled

Eric Chavaillaz CR +2 V +2 Easy +22 −6 updated 01/17/20, 17:14

Commit message

If config.fileTarget is set, per example to "_blank", the target is
set as fallbak on file link. The target is also added on click enlarge
link but it is not wanted if lightbox is enabled.

This patch ensure that the target attribute is not printed when
lightbox is enabled.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Sascha Rademacher +1
    • Henning Liebe +1
  • Verified V +2 Done
    • Benni Mack +2
    • Sascha Rademacher +1
    • Henning Liebe +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1214

  1. Eric Chavaillaz uploaded patch set 1 11/08/19, 10:42

  2. Simon Ackermann voted on patch set 1 CR +1 11/08/19, 10:47

  3. TYPO3com voted on patch set 1 V -1 11/08/19, 11:02 Completed build in 17m 29s on Fri, 8 Nov, 11:02 AM Test Summary: 80 of 48506 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38102

  4. Oli Bartsch commented on patch set 1 V -1 11/08/19, 13:27

    Could you please shorten the summary line a bit and add a proper description about the TASK. It's, at least for me, really hard to get what you changed. Maybe also provide some reasons what's the benefit of this change is. Summary line could be shortened to something like: "Do not add target attribute if lightbox is enabled".
  5. Eric Chavaillaz uploaded patch set 2 11/08/19, 14:35

  6. TYPO3com voted on patch set 2 V +1 11/08/19, 14:51 Completed build in 10m 14s on Fri, 8 Nov, 02:51 PM Test Summary: 48147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38122

  7. Benni Mack commented on patch set 2 12/31/19, 13:19

    Hey Eric, thanks for your patch, I only had a look at it now. Is it possible that "directImageLink" has stdWrap properties, and do we need to take them into account as well?
  8. Benni Mack commented on patch set 2 01/15/20, 11:41

    ping, Eric
  9. Eric Chavaillaz commented on patch set 2 01/16/20, 09:56

    > Patch Set 2: > > ping, Eric Hi, sorry I was in Africa for 3 weeks and I am back this morning. Yes, directImageLink as stdWrap properties. So how can I take this in account to improve the patch? Eric
  10. Benni Mack voted on patch set 2 V +1 CR +1 01/16/20, 15:00

  11. Sascha Rademacher voted on patch set 2 V +1 CR +1 01/17/20, 09:50

  12. Henning Liebe voted on patch set 2 V +1 CR +1 01/17/20, 10:57

  13. Benni Mack voted on patch set 2 V +2 CR +2 01/17/20, 17:14

  14. Benni Mack merged patch set 3 01/17/20, 17:14