Review main Merged

62271[DOCS] Remove confusing "cron command" ambiguity.

TYPO3com CR +2 V +2 Easy +7 −5 updated 11/14/19, 16:04

Commit message

Remove the ambiguity of “cron command” that causes confusion for a
first time reader, as happened in https://forge.typo3.org/issues/75802.
Saying “cron command” implies the entire instruction, including the
shell command portion. Instead, we want only the patterns of the first
five fields of a crontab entry input file line, described in “The Open
Group Base Specifications Issue 7, 2018 edition” at
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/crontab.html.
There is no definitive name for these five fields as a group: “cron
schedule expression” or “crontab schedule expression” are
descriptive.

Review

  • Code review CR +2 Done
    • Daniel Siepmann +2
    • Oli Bartsch +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Daniel Siepmann +2
    • Oli Bartsch +1
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1219

  1. TYPO3com uploaded patch set 1 11/10/19, 22:43

  2. TYPO3com voted on patch set 1 V +1 11/10/19, 22:50 Completed build in 07m 31s on Sun, 10 Nov, 10:50 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38254

  3. Oli Bartsch commented on patch set 1 CR -1 11/10/19, 23:45

    Some formatting can be applied here.
  4. Oli Bartsch uploaded patch set 2 11/10/19, 23:52

  5. Oli Bartsch voted on patch set 2 CR +1 11/10/19, 23:53

  6. Oli Bartsch updated the commit message in patch set 3 11/10/19, 23:58

  7. Oli Bartsch voted on patch set 3 CR +1 11/11/19, 00:00

  8. TYPO3com voted on patch set 2 V +1 11/11/19, 00:00 Completed build in 07m 37s on Mon, 11 Nov, 12:00 AM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38255

  9. TYPO3com voted on patch set 3 V -1 11/11/19, 00:06 Completed build in 07m 35s on Mon, 11 Nov, 12:06 AM Test Summary: 6 of 48655 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38256

  10. TYPO3com voted on patch set 3 V +1 11/11/19, 00:20 Completed build in 07m 29s on Mon, 11 Nov, 12:20 AM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38257

  11. Daniel Siepmann uploaded patch set 4 11/11/19, 09:03

  12. Daniel Siepmann voted on patch set 3 V +1 CR +1 11/11/19, 09:03

  13. Oli Bartsch voted on patch set 4 V +1 CR +1 11/11/19, 09:04

  14. TYPO3com voted on patch set 4 V -1 11/11/19, 09:15 Completed build in 12m 17s on Mon, 11 Nov, 09:15 AM Test Summary: 47811 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38264

  15. TYPO3com voted on patch set 4 V +1 11/11/19, 09:24 Completed build in 08m 01s on Mon, 11 Nov, 09:24 AM Test Summary: 48295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38265

  16. Georg Ringer voted on patch set 4 V +1 CR +1 11/11/19, 12:50

  17. Daniel Siepmann voted on patch set 4 V +1 CR +1 11/11/19, 13:02

  18. Daniel Siepmann voted on patch set 4 V +2 CR +2 11/14/19, 16:04

  19. Daniel Siepmann merged patch set 5 11/14/19, 16:04