Review 9.5 Merged

62281[BUGFIX] Respect config.intTarget and extTarget in default ParseFunc

Daniel Goerz CR +2 V +2 Easy +6 −2 updated 11/17/19, 16:08

Commit message

Fluid Styled Content's "lib.parseFunc" always sets the extTarget (target for
external URLs) to the constant, but never considers config.extTarget anymore.

Same goes for the internal target, where target is never set, as
the target parameter is already filled.

The patch adds some minor inline information as well as
the proper values.

In the future, it would make sense to use the same target values
for config.*target (which is for ALL links and not just the ones in parseFunc)
which should be populated by the constants, and not have the constants
interfer into lib.parseFunc anymore.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1