Review 9.5 Merged

62285[TASK] Do not use constants in low-level classes

Benni Mack CR +2 V +2 Easy +14 −14 updated 11/20/19, 16:30

Commit message

There are certain PHP classes used in the testing framework that
use constants like "LF" which are defined by the SystemEnvironmentBuilder.

The testing framework depends on these classes, but should not
depend on global constants like "LF". The patch changes the lines to "\n"
allowing to continue slimming down testing framework.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3