Review main Merged

62303[TASK] Use consistent checks for USER_INT logic

Benni Mack CR +2 V +2 Easy +8 −4 updated 11/12/19, 17:30

Commit message

A few places in TYPO3 Core do manual checks if there
are non-cacheables on a page, which could be simplified
by just using the $TSFE->isINTincScript() method.

In addition, a safer check for a NON-empty INTincScript
value is used, instead of just a typecheck of array.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Markus Klein +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 712

  1. Benni Mack uploaded patch set 1 11/12/19, 13:27

  2. TYPO3com voted on patch set 1 V -1 11/12/19, 13:41 Completed build in 14m 02s on Tue, 12 Nov, 01:41 PM Test Summary: 35 of 26850 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38298

  3. TYPO3com commented on patch set 1 11/12/19, 13:53 Completed build in 39m 28s on Tue, 12 Nov, 01:53 PM Test Summary: 52 of 48655 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38298

  4. Benni Mack uploaded patch set 2 11/12/19, 14:00

  5. TYPO3com voted on patch set 2 V -1 11/12/19, 14:08 Completed build in 07m 50s on Tue, 12 Nov, 02:08 PM Test Summary: 47547 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38302

  6. Markus Klein commented on patch set 2 11/12/19, 14:42

    TypoScriptFrontendController.php:3112 Unresolved

    lets swap these two expressions to handle a case where $this->config is not set or an empty array.
  7. TYPO3com voted on patch set 2 V +1 11/12/19, 14:42 Completed build in 49m 47s on Tue, 12 Nov, 02:42 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38302

  8. Markus Klein commented on patch set 3 11/12/19, 14:43

    Published edit on patch set 2.
  9. Markus Klein voted on patch set 3 V +1 CR +1 11/12/19, 14:44

  10. TYPO3com voted on patch set 3 V +1 11/12/19, 14:59 Completed build in 15m 33s on Tue, 12 Nov, 02:59 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38304

  11. Georg Ringer voted on patch set 3 V +2 CR +2 11/12/19, 17:30

  12. Georg Ringer merged patch set 4 11/12/19, 17:30